Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to switch pre-build on/off #272

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented Mar 19, 2025

TODO:

  • Add test

@stefanv stefanv added the type: Enhancement New feature or request label Mar 19, 2025
@czgdp1807
Copy link
Contributor

Seems to be working for me,

(scipy-dev) 23:53:12:~/Quansight/scipy % spin test --no-build
$ export PYTHONPATH="/Users/czgdp1807/Quansight/scipy/build-install/usr/lib/python3.12/site-packages:/Users/czgdp1807/Quansight/scipy/build-install/usr/lib/python3.12/site-packages:"
$ /Users/czgdp1807/mambaforge/envs/scipy-dev/bin/python3.12 -P -c 'import scipy'
$ cd /Users/czgdp1807/Quansight/scipy/build-install/usr/lib/python3.12/site-packages
$ /Users/czgdp1807/mambaforge/envs/scipy-dev/bin/python3.12 -P -m pytest -m 'not slow' --pyargs scipy --pyargs scipy
===================================================== test session starts ======================================================
platform darwin -- Python 3.12.0, pytest-8.3.3, pluggy-1.5.0
rootdir: /Users/czgdp1807/Quansight/scipy
configfile: pytest.ini
plugins: cov-6.0.0, hypothesis-6.121.1, timeout-2.3.1, anyio-4.6.2.post1, xdist-3.6.1
collecting 46905 items                                                                                                         ^collected 48031 items                                                                                                          

Aborted!
(scipy-dev) 23:53:53:~/Quansight/scipy % spin test           
Invoking `build` prior to running tests:
$ meson compile -j 10 -C build
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /Users/czgdp1807/mambaforge/envs/scipy-dev/bin/ninja -C /Users/czgdp1807/Quansight/scipy/build -j 10
ninja: Entering directory `/Users/czgdp1807/Quansight/scipy/build'
[2/338] Generating subprojects/highs/src/HConfig.h with a custom command
$ meson install --only-changed -C build --destdir ../build-install --tags=runtime,python-runtime,tests,devel
^C
Aborted!

So I am approving.

Copy link
Contributor

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with reference to #272 (comment)

@czgdp1807
Copy link
Contributor

@stefanv Is this PR good to go? It worked well for me.

cc: @rgommers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants