Skip to content

fix: fill_flattened broadcasting of non user kwargs #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jammf
Copy link

@Jammf Jammf commented Jun 8, 2025

When usingfill_flattened with multiple args and either the weight or sample kwargs, it tries to broadcast the keys of non_user_kwargs instead of the values, leading to kwargs trying to fill the histogram with the stringified kwarg name instead of its value (such as the sample kwarg attempting to fill the array with ["sample", "sample", "sample", "sample"]). This PR changes that behavior to insert the values instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant