fix: fill_flattened
broadcasting of non user kwargs
#612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
fill_flattened
with multiple args and either theweight
orsample
kwargs, it tries to broadcast the keys ofnon_user_kwargs
instead of the values, leading to kwargs trying to fill the histogram with the stringified kwarg name instead of its value (such as thesample
kwarg attempting to fill the array with["sample", "sample", "sample", "sample"]
). This PR changes that behavior to insert the values instead.