MNT Fix error message for Minkowski metric parameter - #19671
Merged
Merged
Conversation
It is possible to pass p=1 for `minkowski` metric, even though internally the effective metric gets changed to `manhattan`. This PR simply edits the two error messages to not confuse the users.
thomasjpfan
reviewed
Mar 13, 2021
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR @zouharvi !
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to pass p=1 for
minkowskimetric, even though internally the effective metric gets changed tomanhattan.This PR simply edits the two error messages to not confuse the users.