[Improvement] add easyreg option to subworkflow/registration#215
Open
anroy1 wants to merge 5 commits intoscilus:mainfrom
Open
[Improvement] add easyreg option to subworkflow/registration#215anroy1 wants to merge 5 commits intoscilus:mainfrom
anroy1 wants to merge 5 commits intoscilus:mainfrom
Conversation
pull-request-management
bot
requested review from
AlexVCaron and
GuillaumeTh
anroy1
changed the title
anroy1
force-pushed
the
sf-registration-sw
branch
from
de30e88 to
acda670
Compare
AlexVCaron
changed the title
AlexVCaron
requested changes
Sep 13, 2024
Collaborator
AlexVCaron
left a comment
AlexVCaron
left a comment
There was a problem hiding this comment.
Very nice work ! I think we can merge this fast after another round of review. My comments target syntax mostly. Also, some comments should move you forward to tests working.
GuillaumeTh
reviewed
Sep 16, 2024
GuillaumeTh
left a comment
GuillaumeTh
left a comment
There was a problem hiding this comment.
Good job ! Some small comments from my side.
| .map{ it + [[]] } | ||
| transfo_trk = REGISTRATION_EASYREG.out.bak_field | ||
| .map{ [[]] + it } | ||
| ref_warped - REGISTRATION_EASYREG.out.ref_reg |
Contributor
Author
There was a problem hiding this comment.
Are you referring to ".map{ [[]] + it } or ref_warped output declaration?
There was a problem hiding this comment.
In fact it is not a = but a -. So I think you have a bug here.
anroy1
force-pushed
the
sf-registration-sw
branch
from
bea6c73 to
f22cc49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add the synthbet option to preproc_t1
List test packages used by your module
processing.zipChecklist before requesting a review
./modules/nf-scil/<category>/<tool>/main.nf./modules/nf-scil/<category>/<tool>/meta.yml./tests/modules/nf-scil/<category>/<tool>/main.nf./tests/modules/nf-scil/<category>/<tool>/nextflow.configTo Do
niftiMD5SUM
add conditionnal warpconvert