Do not duplicate output of timeseries jobs as cumulative/current #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both return the full timeseries. It is likely that we may want to switch to only publishing the new value, but that would be a larger change since it requires collecting the timeseries in the frontend.
MridulS
approved these changes
Oct 2, 2025
The test was expecting 2 messages (cumulative and current) but the branch changes timeseries_handler.py to only output cumulative data, eliminating the duplicate output. Updated test assertions to expect 1 message per workflow execution instead of 2. Original prompt: Branch timeseries-duplicate-output does not pass builds. Please fix if possible, then commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both return the full timeseries. It is likely that we may want to switch to only publishing the new value, but that would be a larger change since it requires collecting the timeseries in the frontend.