Fix image plot to also accept position updates #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eed to change mode. So we need to unify fast and mesh image into a single class
jl-wynen
reviewed
Sep 8, 2025
| self._xmin, self._xmax = self._bin_edge_coords["x"].values[[0, -1]] | ||
| self._ymin, self._ymax = self._bin_edge_coords["y"].values[[0, -1]] | ||
| self._dx = np.diff(self._bin_edge_coords["x"].values[:2]) | ||
| self._dy = np.diff(self._bin_edge_coords["y"].values[:2]) |
There was a problem hiding this comment.
Ideally, you wouldn't define attributes of self outside of __init__. And I don't like that these attrs only exist for the optimized mode.
Can you use composition to have a FastImage or MeshImage object inside Image? This might also get rid of the if self._optimized_mode: checks scattered everywhere.
|
I'm having second thoughts about this and #484. For the scatter3d plot it's leading to significant performance penalty... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #485
It is possible that the initial image has linspace coords (and thus rendered with
imshow) and a subsequent update has non-linspace coords (should be rendered usingpcolormesh).Plopp is not really designed to swap artists in and out, so we merge the
FastImageandMeshImageclasses into a single one that handles both cases depending on linspace state.