MAINT: close the figures before backend change #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPL 3.8 issues a DeprecationWarning, follow its suggestion
Sheila-nk
approved these changes
Mar 12, 2024
|
LGTM! 🚀 |
|
I'm not sure if you can see the same warning locally: scpdt/tests/test_testfile.py::test_linalg_clone
<doctest scipy_linalg_tutorial_clone.rst[69]>:1: UserWarning: FigureCanvasAgg is non-interactive, and thus cannot be shownbut is it possible to silence this warning as well in this PR or a follow-up PR? |
|
A follow-up sounds good. |
|
Thanks for the review Sheila! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPL 3.8 issues a DeprecationWarning, follow its suggestion:
scpdt/tests/test_testfile.py::test_one_scipy_tutorial
Auto-close()ing of figures upon backend switching is deprecated since 3.8 and will be removed two minor releases later. To suppress this warning, explicitly call plt.close('all') first.
matplotlib.use('Agg')
Found while looking at gh-131