Numpy 2.2 abbreviations #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy 2.2 added shape= to the repr of abbreviated arrays. This is not a legal argument to `array(...)` constructor, thus the result cannot be eval-ed. Handle this case by removing the shape= bit.
ev-br
force-pushed
the
numpy_2.2_abbrev
branch
from
b689ce7 to
fde8782
Compare
with and without shapes=
ev-br
force-pushed
the
numpy_2.2_abbrev
branch
from
fde8782 to
dc9a25c
Compare
|
Going to merge straight away and proceed to releasing to pypi to unblock scipy. Post-merge reviews are most welcome though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy 2.2 added shape= to the repr of abbreviated arrays. This is not a legal argument to
array(...)constructor, thus the result cannot be eval-ed.Thus, remove the
shape=...bit, if present, from bothwantandgot. Then try to cater for both "new" and "old" numpy outputs:shape=is present in the output, i.e. on NumPy >= 2.2, compare both shapes and valuesshape=is not present in the output, i.e. on NumPy < 2.2, only compare the values.This way, doctests written in the numpy 2.2+ format, continue working across all numpy versions. Doctests written for the "old" format do not work on numpy 2.2+ and need a tweak to add
shapes=....closes gh-175