-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: collect doctests from docstrings of data descriptors #180
Conversation
cc @mattip seems to be working as a workaround for numpy/numpy#28002, would you double-check? |
scipy_doctest/impl.py
Outdated
tests += super().find( | ||
method, f'{name}.{name_}', module, globs, extraglobs | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason to collect the descriptors, or could this be rewritten as
for name_, method in inspect.getmembers(obj):
if inspect.isdatadescriptor(method):
tests += super().find(
method, f'{name}.{name_}', module, globs, extraglobs
)
Not critical, whatever you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one little nit.
Thanks Matti! Adopted your spelling of the snippet, it's nicer indeed. And it's in. |
Will you be tagging a new release? |
I'd like to have gh-179 in it, too. |
OK, |
cross-ref python/cpython#127962, numpy/numpy#28002
fixes gh-178