tests: remove impala integration tests

[murfffi]

Now that sclgo/impala-go was added to usql, the remaining value of impala-go tests
is insufficient given the high cost of Impala startup.

--replace functionality is sufficiently testsed in gen_test.go

[gemini-code-assist]

Hello @murfffi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request removes the Impala integration tests. The author, murfffi, argues that with the addition of sclgo/impala-go to usql, the cost of maintaining the Impala tests outweighs their value. The functionality tested in the removed tests is now sufficiently covered in gen_test.go, specifically the --replace functionality.

Highlights

• Test Removal: The primary change is the removal of the internal/integrationtest/impala/impala_test.go file, which contained integration tests for Impala.
• Justification: The PR description states that the tests are being removed because their value is no longer worth the cost, given the addition of sclgo/impala-go to usql and sufficient testing of --replace in gen_test.go.

Changelog

• internal/integrationtest/impala/impala_test.go
  • The entire file has been removed, deleting all Impala integration tests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

The Impala tests take flight,
Their purpose served, they fade from sight.
New paths we tread,
No tears to shed,
In testing's ever-changing light.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request removes the Impala integration tests. The rationale is that with the addition of sclgo/impala-go to usql, the value of maintaining these tests is no longer worth the cost of Impala startup. The replace functionality is sufficiently tested in gen_test.go.

Summary of Findings

• Test removal justification: The justification for removing the Impala integration tests seems reasonable, given the added sclgo/impala-go driver and the cost of Impala startup. However, it's important to ensure that the remaining tests adequately cover the functionality previously tested by the Impala integration tests.

Merge Readiness

The removal of the Impala integration tests appears justified based on the description. However, it's crucial to verify that the existing tests, particularly those in gen_test.go, sufficiently cover the functionality previously tested by the removed tests. I am unable to approve the pull request in any circumstance, and that users should have others review and approve this code before merging.