Add PyTest suite to mariadb-container #311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration matrix is: - run_container_creation_tests -> test_container_configuration.py(test_try_image_invalid_combinations, test_container_creation_fails, test_invalid_configuration_tests.py - run_configuration_tests -> test_container_configuration.py(TestMariaDBConfigurationTests and TestsMariaDBConfiguratioTest) TestMariaDB - run_general_tests -> test_container_general.py(test_run and test_datadir) - run_change_password_test -> test_container_password.py - run_change_password_new_user_test -> test_container_password.py - run_replication_test -> test_container_replication.py - run_s2i_test -> test_container_basics.py - run_ssl_test -> test_container_basics.py - run_upgrade_test -> test_container_upgrade.py - run_plugin_test -> test_container_plugin.py Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
[test-pytest] |
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
Testing Farm results
|
Lets' connect to proper DB including --disable certificates Let's check if Slave is really runnning before SQL command is called. Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
[test-pytest] |
Call sql commands at once. Change initial names to understandable. Use DatabaseWrapper directly to call sql commands. Check mariadb configuration values together. Do not duplicate code. Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
re-trigger tests after a hude refactoring. [test][test-pytest] |
Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
container_pytests
branch
from
6bd423f to
f990c37
Compare
Member
Author
|
re-trigger tests after fixing issue on Fedora [test][test-pytest] |
and parametrized it. It is easier to review code. Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
[test][test-pytest] |
Member
Author
|
@frenzymadness PTAL in case you have free time. |
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
This PR adds 1355 lines of code so it will take a while to review it. I'm submitting what I have so far so we can ping-pong small portions of it.
is defined in VARS variable directly Signed-off-by: Petr "Stone" Hracek <[email protected]>
Update also description for better reading what each test does in case it is huge Signed-off-by: Petr "Stone" Hracek <[email protected]>
if mariadb contains proper settings Signed-off-by: Petr "Stone" Hracek <[email protected]>
The function is already part of container-ci-suite. Add several documentation part to the tests Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
container_pytests
branch
from
d218b68 to
2d65c49
Compare
Member
Author
|
@frenzymadness I have tryied to address all issues. As soon as you will have a spare time. Please look at this. Next time, we can add each test by simple PR for better review. It makes sense for me to PostgreSQL container. |
Member
Author
|
[test-pytest][test] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration matrix is: