Migration bash test suite to Pytest #501

phracek · 2025-10-06T09:39:42Z

This pull request migrates bash test suite to PyTest suite.

It is separated to these commits:

Rename OpenShit Pytests to test_ocp_*
Add PyTest to s2i-php-container to directory test/test_container_*
Add symlinks to all supported versions

github-actions · 2025-10-06T09:40:15Z

Pull Request validation

Failed

🔴 Review - Missing review from a member (1 required)

Success

🟢 CI - All checks have passed

github-actions · 2025-10-06T09:40:16Z

Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

Auto Merge

Failed

🔴 Pull Request has unsupported target branch master, expected branches are: ''

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟢 Pull Request meet requirements, mergeable_state is clean

phracek · 2025-10-06T10:06:21Z

[test-pytest]

github-actions · 2025-10-06T10:12:44Z

Testing Farm results

name	compose	arch	status	started (UTC)	time	logs
Fedora - PyTest - 8.3	Fedora-latest	x86_64	✅ passed	29.10.2025 11:21:34	9min 38s	test pipeline
Fedora - PyTest - 8.2	Fedora-latest	x86_64	✅ passed	29.10.2025 11:21:41	9min 15s	test pipeline
CentOS Stream 9 - PyTest - 8.3	CentOS-Stream-9	x86_64	✅ passed	29.10.2025 11:21:36	11min 6s	test pipeline
CentOS Stream 10 - PyTest - 8.3	CentOS-Stream-10	x86_64	✅ passed	29.10.2025 11:21:34	10min 41s	test pipeline
RHEL10 - PyTest - 8.3	RHEL-10-Nightly	x86_64	✅ passed	29.10.2025 11:21:34	12min 58s	test pipeline
RHEL8 - PyTest - 7.4	RHEL-8.10.0-Nightly	x86_64	✅ passed	29.10.2025 11:21:42	15min 6s	test pipeline
RHEL8 - PyTest - 8.2	RHEL-8.10.0-Nightly	x86_64	✅ passed	29.10.2025 11:21:34	15min 51s	test pipeline
RHEL9 - PyTest - 8.3	RHEL-9.6.0-Nightly	x86_64	✅ passed	29.10.2025 11:21:35	17min 7s	test pipeline
RHEL9 - PyTest - 8.2	RHEL-9.6.0-Nightly	x86_64	✅ passed	29.10.2025 11:21:35	18min 2s	test pipeline
RHEL10 - OpenShift 4 - 8.3	RHEL-10-Nightly	x86_64	❌ error	27.10.2025 15:42:13	21min 11s	test pipeline
Fedora - 8.3	Fedora-latest	x86_64	✅ passed	29.10.2025 11:22:01	7min 31s	test pipeline
Fedora - 8.2	Fedora-latest	x86_64	✅ passed	29.10.2025 11:22:14	7min 49s	test pipeline
CentOS Stream 9 - 8.3	CentOS-Stream-9	x86_64	✅ passed	29.10.2025 11:22:10	11min 20s	test pipeline
RHEL9 - OpenShift 4 - 8.3	RHEL-9.6.0-Nightly	x86_64	✅ passed	27.10.2025 15:28:12	39min 55s	test pipeline
CentOS Stream 10 - 8.3	CentOS-Stream-10	x86_64	✅ passed	29.10.2025 11:22:12	10min 6s	test pipeline
RHEL9 - OpenShift 4 - 8.0	RHEL-9.6.0-Nightly	x86_64	✅ passed	27.10.2025 15:58:52	20min 41s	test pipeline
RHEL9 - OpenShift 4 - 8.2	RHEL-9.6.0-Nightly	x86_64	✅ passed	27.10.2025 15:03:25	1h 3min 10s	test pipeline
RHEL8 - OpenShift 4 - 8.2	RHEL-8.10.0-Nightly	x86_64	✅ passed	27.10.2025 16:01:21	17min 20s	test pipeline
RHEL9 - 8.3	RHEL-9.6.0-Nightly	x86_64	✅ passed	29.10.2025 10:23:34	16min 36s	test pipeline
RHEL9 - 8.0	RHEL-9.6.0-Nightly	x86_64	✅ passed	29.10.2025 11:22:22	17min 19s	test pipeline
RHEL8 - OpenShift 4 - 7.4	RHEL-8.10.0-Nightly	x86_64	✅ passed	27.10.2025 15:59:40	17min 53s	test pipeline
RHEL10 - 8.3	RHEL-10-Nightly	x86_64	✅ passed	29.10.2025 11:22:04	12min 28s	test pipeline
RHEL8 - 7.4	RHEL-8.10.0-Nightly	x86_64	✅ passed	29.10.2025 11:22:01	14min 20s	test pipeline
RHEL8 - 8.2	RHEL-8.10.0-Nightly	x86_64	✅ passed	29.10.2025 11:21:44	13min 29s	test pipeline
RHEL9 - 8.2	RHEL-9.6.0-Nightly	x86_64	✅ passed	29.10.2025 11:21:57	16min 47s	test pipeline
RHEL9 - PyTest - 8.0	RHEL-9.6.0-Nightly	x86_64	✅ passed	29.10.2025 11:21:44	17min 58s	test pipeline
RHEL10 - PyTest - OpenShift 4 - 8.3	RHEL-10-Nightly	x86_64	❌ error	27.10.2025 15:37:28	24min 38s	test pipeline
RHEL8 - PyTest - OpenShift 4 - 7.4	RHEL-8.10.0-Nightly	x86_64	❌ error	27.10.2025 16:04:11	27min 2s	test pipeline
RHEL9 - PyTest - OpenShift 4 - 8.0	RHEL-9.6.0-Nightly	x86_64	❌ error	27.10.2025 16:02:14	1h 13min 7s	test pipeline
RHEL8 - PyTest - OpenShift 4 - 8.2	RHEL-8.10.0-Nightly	x86_64	❌ error	27.10.2025 15:02:11	1h 37min 46s	test pipeline
RHEL9 - PyTest - OpenShift 4 - 8.3	RHEL-9.6.0-Nightly	x86_64	❌ error	27.10.2025 15:03:18	1h 42min 28s	test pipeline
RHEL9 - PyTest - OpenShift 4 - 8.2	RHEL-9.6.0-Nightly	x86_64	❌ error	27.10.2025 15:17:59	1h 28min 45s	test pipeline

phracek · 2025-10-13T13:12:56Z

[test-all]

Signed-off-by: Petr "Stone" Hracek <[email protected]>

what each test does. Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2025-10-15T08:42:52Z

[test-pytest][test-openshift]

phracek · 2025-10-15T08:44:00Z

@frenzymadness The tests have been rewritten based on your small improvements in s2i-python-container.

The suite was rewritten like in s2i-perl-container pull request sclorg/s2i-perl-container#346

So PTAL. Not urgent.

Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2025-10-16T10:42:48Z

[test-pytest][test-openshift]

frenzymadness

Possible improvements found.

test/test_container_application.py

test/test_container_ssl.py

test/test_ocp_php_deploy_templates.py

test/test_ocp_php_latest_imagestreams.py

use container args in case OS is "rhel9" or "rhel10" Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2025-10-20T10:26:09Z

[test-pytest][test]

phracek · 2025-10-20T11:22:56Z

@frenzymadness The issues have been resolved. Thanks. Fantastic review.

frenzymadness

I'm sorry but it seems my suggestions were mostly ignored. That's, of course, fine, but it'd be nice to share the reason.

test/test_container_application.py

I do not now, what I have done. Sorry for wasting your time Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2025-10-22T09:45:36Z

[test-pytest][test]

frenzymadness

One last nitpick from me.

test/conftest.py

frenzymadness

Thank you for your patience!

Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2025-10-27T15:01:00Z

[test-all]

phracek · 2025-10-29T10:22:36Z

Let's re-test it after fixing branch

[test][test-pytest]

Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2025-10-29T11:21:22Z

Let's re-test it after fixing branch

[test][test-pytest]

phracek · 2025-10-29T11:48:34Z

/auto-merge

github-actions bot added the pr/missing-review label Oct 6, 2025

github-actions bot added the pr/failing-ci label Oct 6, 2025

github-actions bot removed the pr/failing-ci label Oct 7, 2025

phracek added READY-to-MERGE ready for review and removed READY-to-MERGE labels Oct 9, 2025

github-actions bot added pr/failing-ci and removed pr/failing-ci labels Oct 13, 2025

phracek added 2 commits October 15, 2025 10:31

Add PyTest suite for testing container tests

eb26d9f

Signed-off-by: Petr "Stone" Hracek <[email protected]>

Rename test_php_*.py to test_ocp_*.py

ed28446

Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek force-pushed the container_pytests branch from bcfdb11 to ed28446 Compare October 15, 2025 08:34

Add documentation to each test, so we see

e8d92ab

what each test does. Signed-off-by: Petr "Stone" Hracek <[email protected]>

github-actions bot added the pr/failing-ci label Oct 15, 2025

Move TAG to VARS and MYSQL_VERSION as well.

4b49b0e

Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek requested a review from frenzymadness October 17, 2025 07:19

frenzymadness reviewed Oct 17, 2025

View reviewed changes

github-actions bot removed the pr/failing-ci label Oct 17, 2025

Remove obsolete Python parametrization and

8e95f51

use container args in case OS is "rhel9" or "rhel10" Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek force-pushed the container_pytests branch from bf4bc63 to 8e95f51 Compare October 20, 2025 08:38

github-actions bot added the pr/failing-ci label Oct 20, 2025

frenzymadness reviewed Oct 22, 2025

View reviewed changes

test/test_container_application.py Outdated Show resolved Hide resolved

test/test_container_application.py Outdated Show resolved Hide resolved

Fix changes that was proposed by @frenzymadness.

0bc9061

I do not now, what I have done. Sorry for wasting your time Signed-off-by: Petr "Stone" Hracek <[email protected]>

github-actions bot removed the pr/failing-ci label Oct 22, 2025

github-actions bot added the pr/failing-ci label Oct 22, 2025

frenzymadness reviewed Oct 23, 2025

View reviewed changes

test/conftest.py Outdated Show resolved Hide resolved

test/conftest.py Outdated Show resolved Hide resolved

github-actions bot removed the pr/failing-ci label Oct 23, 2025

frenzymadness approved these changes Oct 24, 2025

View reviewed changes

github-actions bot added pr/failing-ci and removed pr/missing-review labels Oct 24, 2025

Remove obsoleted variables that are not used at all.

728c045

Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek force-pushed the container_pytests branch from b04a463 to 728c045 Compare October 27, 2025 15:00

github-actions bot added pr/needs-manual-merge and removed pr/failing-ci labels Oct 29, 2025

github-actions bot added the pr/failing-ci label Oct 29, 2025

Fix BRANCH_TO_TEST. It is either 4.X or 5.X

0269272

Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek force-pushed the container_pytests branch from b24eba4 to 0269272 Compare October 29, 2025 11:21

phracek added the READY-to-MERGE label Oct 29, 2025

github-actions bot removed the pr/failing-ci label Oct 29, 2025

phracek merged commit b9bee58 into master Oct 29, 2025
21 checks passed

phracek deleted the container_pytests branch October 29, 2025 11:49

Migration bash test suite to Pytest #501

Migration bash test suite to Pytest #501

Uh oh!

Conversation

phracek commented Oct 6, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 6, 2025

Pull Request validation

Failed

Success

Uh oh!

github-actions bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request validation

Success

Auto Merge

Failed

Success

Uh oh!

phracek commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Farm results

Uh oh!

phracek commented Oct 13, 2025

Uh oh!

phracek commented Oct 15, 2025

Uh oh!

phracek commented Oct 15, 2025

Uh oh!

phracek commented Oct 16, 2025

Uh oh!

frenzymadness left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phracek commented Oct 20, 2025

Uh oh!

phracek commented Oct 20, 2025

Uh oh!

frenzymadness left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

phracek commented Oct 22, 2025

Uh oh!

frenzymadness left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

frenzymadness left a comment

Choose a reason for hiding this comment

Uh oh!

phracek commented Oct 27, 2025

Uh oh!

phracek commented Oct 29, 2025

Uh oh!

phracek commented Oct 29, 2025

Uh oh!

phracek commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

phracek commented Oct 6, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Oct 6, 2025 •

edited

Loading

github-actions bot commented Oct 6, 2025 •

edited

Loading