Skip to content

Eliminating Ruby warnings #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amatsuda wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Eliminating Ruby warnings #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5107c39
"warning: shadowing outer local variable - thing"
amatsuda Jul 24, 2014
fb4b28c
"warning: assigned but unused variable - accepts_object"
amatsuda Jul 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/predicated/print.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ def inspect(indent="")

private
def part_to_s(thing)
part_to_str(thing) {|thing| thing.to_s}
part_to_str(thing) {|t| t.to_s}
end

def part_inspect(thing, indent="")
part_to_str(thing, indent) {|thing| thing.inspect(indent)}
part_to_str(thing, indent) {|t| t.inspect(indent)}
end

def part_to_str(thing, indent="")
Expand Down
2 changes: 1 addition & 1 deletion lib/predicated/to/sentence.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def self.reset_verb_phrases

register_verb_phrase(:include?, "includes", "does not include")
register_verb_phrase(:is_a?, "is a", "is not a")
register_verb_phrase(:nil?, "is nil", "is not nil", accepts_object=false)
register_verb_phrase(:nil?, "is nil", "is not nil", false)

nil
end
Expand Down