Skip to content

feat(schema); add files and volumes short support#189

Draft
lekaf974 wants to merge 5 commits into
score-spec:mainfrom
lekaf974:feat/add-files-and-volumes-short-support
Draft

feat(schema); add files and volumes short support#189
lekaf974 wants to merge 5 commits into
score-spec:mainfrom
lekaf974:feat/add-files-and-volumes-short-support

Conversation

@lekaf974

Copy link
Copy Markdown
Contributor

Description

Add files and volumes shortland support

What does this PR do?

Fix score-spec/spec#196

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

lekaf974 added 2 commits May 20, 2026 21:20
…and volumes

Signed-off-by: lekaf974 <matthieu.evrin@gmail.com>
…volumes

Signed-off-by: lekaf974 <matthieu.evrin@gmail.com>

@mathieu-benoit mathieu-benoit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep the 3 options in place here?

variables:
SOME_VAR: some content here
files:
- target: /my/file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To still be retro compatible, and making sure that "old" Score files work, we should keep this here, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that change wasn't intentional; I'll update it soon.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks it comes from original samples/score-full.yaml from score-spec/spec will rollback and just update existing file in score-spec/score-go

@lekaf974
lekaf974 marked this pull request as draft May 29, 2026 01:42
lekaf974 added 3 commits May 28, 2026 21:44
Signed-off-by: lekaf974 <matthieu.evrin@gmail.com>
…orthand support

Signed-off-by: lekaf974 <matthieu.evrin@gmail.com>
…and normalization

Signed-off-by: lekaf974 <matthieu.evrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Shorthand way to define files and volumes

2 participants