feat: Support placeholder substitution in container image - #350
Open
joeljeske wants to merge 1 commit into
Open
Conversation
7 tasks
Contributor
|
Thanks for your contribution, @joeljeske! The DCO is failing, to fix it you can run this in your local branch: git rebase HEAD~1 --signoff
git push --force-with-lease origin feat/image-ref |
joeljeske
force-pushed
the
feat/image-ref
branch
from
July 31, 2026 01:57
4fca46b to
3e54d13
Compare
Signed-off-by: Joel Jeske <joeljeske14@gmail.com>
joeljeske
force-pushed
the
feat/image-ref
branch
from
July 31, 2026 02:00
3e54d13 to
f8e095c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Placeholders already resolve in
containers.*.variables,containers.*.files,containers.*.volumes.sourceandresources.*.params, butcontainers.*.imagewas passed through verbatim. This resolves the image withthe same substituter already used for variables, so it sees exactly the same
refs:
What does this PR do?
It makes the image field composable from resource outputs and workload
metadata, instead of requiring the caller to rewrite the score file or pass
--image. --image takes a single value per invocation, so it can't serve
multiple workloads generated together, and it only applies to image: ".".
The omission looks incidental rather than deliberate: the substitution
machinery is generic, resources are fully provisioned before conversion so
outputs are already available, and no test asserted that a placeholder in
image stays literal.
Types of changes
Checklist:
Related: score-spec/score-compose#538