Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with boost-1.85 #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefantalpalaru
Copy link

No description provided.

@Tabby
Copy link

Tabby commented Jul 16, 2024

This header has "only" been deprecated since Boost 1.50 (though I'd guess it got deprecated as part of the move to Filesystem V3 which happened earlier than that, it's just that V2 was kept around for a while for compatibility).

Even though that version is about 12 years old, ElectricSheep still lists the even older 1.39 as the minimum version, so this change should probably either bump the minimum version, or conditionally change which includes are used based on the version of Boost in use

@Schievel1
Copy link
Contributor

I think we shouldn't bump the minimum version, as this would break compilation for many older systems. After all boost 1.85 is only a few months old.
I made a PR to include the right file depending on the boost version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants