Skip to content

fix(validator): enforce validator role on milestone endpoints (closes #210) #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Petah1 merged 1 commit into from
Jun 20, 2026
+22 −0
Merged

fix(validator): enforce validator role on milestone endpoints (closes #210) #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions tests/routes/validator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ function makeToken(wallet: string, role: string): string {
const VALIDATOR_WALLET = 'GVALIDATOR1AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA';
const PLAYER_WALLET = 'GPLAYER1AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA';
const SCOUT_WALLET = 'GSCOUT1AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA';
const ADMIN_WALLET = 'GADMIN1AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA';

beforeEach(() => {
mockGetEvents.mockReset();
Expand Down Expand Up @@ -73,6 +74,17 @@ describe('POST /api/validators/milestone', () => {
expect(res.body.error).toBe('Insufficient permissions');
});

it('returns 403 when user is an admin', async () => {
const adminToken = makeToken(ADMIN_WALLET, 'admin');
const res = await request(app)
.post('/api/validators/milestone')
.set('Authorization', `Bearer ${adminToken}`)
.send(validPayload);
expect(res.status).toBe(403);
expect(res.body.success).toBe(false);
expect(res.body.error).toBe('Insufficient permissions');
});

it('returns 201 when user is a validator with valid payload', async () => {
const validatorToken = makeToken(VALIDATOR_WALLET, 'validator');
const res = await request(app)
Expand Down Expand Up @@ -123,6 +135,16 @@ describe('GET /api/validators/milestones/pending', () => {
expect(res.body.error).toBe('Insufficient permissions');
});

it('returns 403 when user is an admin', async () => {
const adminToken = makeToken(ADMIN_WALLET, 'admin');
const res = await request(app)
.get('/api/validators/milestones/pending')
.set('Authorization', `Bearer ${adminToken}`);
expect(res.status).toBe(403);
expect(res.body.success).toBe(false);
expect(res.body.error).toBe('Insufficient permissions');
});

it('returns 200 with empty array when validator has no pending milestones', async () => {
mockGetEvents.mockReturnValue([]);
const validatorToken = makeToken(VALIDATOR_WALLET, 'validator');
Expand Down
Loading