Use platform.system(), remove Python version check

scrapy-plugins · Jun 14, 2024 · 53ff9ee · 53ff9ee
1 parent 24decd3
commit 53ff9ee
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/scrapy_playwright/handler.py b/scrapy_playwright/handler.py
@@ -1,6 +1,6 @@
-import sys
 import asyncio
 import logging
+import platform
 from contextlib import suppress
 from dataclasses import dataclass
 from ipaddress import ip_address
@@ -45,8 +45,7 @@
 __all__ = ["ScrapyPlaywrightDownloadHandler"]
 
 
-# Supporting for Windows
-if sys.platform == "win32" and sys.version_info >= (3, 8):
+if platform.system() == "Windows":
     import threading
 
     class Var:
@@ -74,7 +73,6 @@ def deferred_from_coro(o):
         return deferred_from_coro_default(windows_get_result(o))
 
 else:
-    windows_get_asyncio_event_loop = None
     windows_get_result = None
     deferred_from_coro = deferred_from_coro_default
 

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -1,4 +1,5 @@
-import sys
+import platform
+
 import pytest
 
 
@@ -9,8 +10,7 @@ def pytest_configure(config):
 
     if (
         config.getoption("reactor", "default") == "asyncio"
-        and sys.platform == "win32"
-        and sys.version_info >= (3, 8)
+        and platform.system() == "Windows"
     ):
         import asyncio