Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix freezing on responses with status 204 #292

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Fix freezing on responses with status 204 #292

merged 3 commits into from
Jul 6, 2024

Conversation

elacuesta
Copy link
Member

Closes #288

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.20%. Comparing base (ca8cc46) to head (dea2a1c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   93.04%   93.20%   +0.16%     
==========================================
  Files           6        6              
  Lines         546      559      +13     
==========================================
+ Hits          508      521      +13     
  Misses         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elacuesta elacuesta changed the title Do not freeze on responses with status 204 Fix freezing on responses with status 204 Jul 6, 2024
@elacuesta elacuesta added the bug Something isn't working label Jul 6, 2024
@elacuesta elacuesta added this to the v0.0.38 milestone Jul 6, 2024
@elacuesta elacuesta merged commit 55528dc into main Jul 6, 2024
16 checks passed
@elacuesta elacuesta deleted the fix-204-freeze branch July 6, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser breaks with new tab on empty content response
1 participant