Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only register request and response loggers when needed #336

Merged

Conversation

jl-martins
Copy link
Contributor

Closes #335

@elacuesta
Copy link
Member

Great work, thank you! CI failures are unrelated, I'm working on them in separate PRs, I'll merge this one once I sort those issues out.

@jl-martins
Copy link
Contributor Author

Thanks, @elacuesta!

@elacuesta
Copy link
Member

Look at that, I worked on something similar a few months ago and completely forgot about it 😂 5de5a52

@elacuesta elacuesta merged commit de11854 into scrapy-plugins:main Feb 19, 2025
5 checks passed
@jl-martins jl-martins deleted the request-response-loggers-optimization branch February 19, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance optimization: Only register request and response loggers when needed
2 participants