Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright install with deps #338

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Playwright install with deps #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25f4b02
Playwright install: add --with-deps
elacuesta Feb 14, 2025
d4c3a55
Set OS versions explicitly
elacuesta Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ jobs:
timeout-minutes: 20
strategy:
fail-fast: false
os: ubuntu-22.04
matrix:
os: [ubuntu-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
include:
- os: macos-latest
- os: macos-14
python-version: "3.12"
- os: windows-latest
- os: windows-2022
python-version: "3.12"

steps:
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ allowlist_externals =
npm
npx
commands =
playwright install
playwright install --with-deps
npm install [email protected]
npx playwright install chromium
py.test -vv --reactor=asyncio \
Expand All @@ -29,7 +29,7 @@ basepython = python3
[testenv:py-twisted]
basepython = python3
commands =
playwright install
playwright install --with-deps
py.test -vv --reactor=asyncio \
--cov-report=term-missing \
--cov-report=xml:coverage-twisted.xml \
Expand Down