fix: accept application/x-scratch3-sprite for sprite uploads #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing <https://aur.archlinux.org/packages/scratch3> (or the `-bin` version) registers the `application/x-scratch3-sprite` type with the system (see `/usr/share/mime/scratch3.xml`), which is kinda cool, but it also causes certain browsers to report `sprite3` files with that MIME type during file upload. So, if you have one of those two applications installed, sprite upload fails. That includes integration tests. Fun!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
It seems likely that this issue was already filed, maybe years ago, but I couldn't find it. I found several issues suggesting that we do something about our MIME types, just... not this particular issue 😅
Proposed Changes
Add
application/x-scratch3-spriteto the list of accepted "file types" for sprite upload.Reason for Changes
Installing https://aur.archlinux.org/packages/scratch3 (or the
-binversion) registers theapplication/x-scratch3-spritetype with the system (see/usr/share/mime/scratch3.xml), which is kinda cool, but it also causes certain browsers to reportsprite3files with that MIME type during file upload. So, if you have one of those two applications installed, sprite upload fails. That includes the copy of Chromium that I use for integration tests. Fun!Test Coverage
Tested locally after investigating why integration tests were failing for me but passing on CI...