Address review comments in #1061 #1108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kunxian xia <[email protected]>
Co-authored-by: Ming <[email protected]>
- simplify index computation of affine_add(left, right) - allocate buffer once and parallel initialization
#1061 Cleanup - [x] clippy fixes - [x] remove old unused routines for generating witness for the ecc summation tower tree. Note this approach is abandoned. We prefer to pack $log_2(N)$ layers in one layer using the relation `p[1, b] = ec_add(p[0,b], p[1,b])` (first proposed in Quark paper.
kunxian-xia
commented
Oct 31, 2025
| cb.condition_require_zero( | ||
| || "global_write = true => shard = instance.shard", | ||
| is_global_write.expr(), | ||
| shard.expr() - Expression::Instance(cur_shard), |
Collaborator
Author
There was a problem hiding this comment.
main sumcheck does not support public inputs now.
Collaborator
There was a problem hiding this comment.
please try this way
let cur_shard = cb.query_shard_id();
cur_shard.expr() // this return `Expression::InstanceScalar()` which make thing work in sumcheck
hero78119
reviewed
Nov 1, 2025
| } | ||
|
|
||
| #[inline(always)] | ||
| pub fn cur_shard(&self) -> usize { |
Collaborator
There was a problem hiding this comment.
nitpick: cur_shard_id() or shard_id() better
| cb.condition_require_zero( | ||
| || "global_write = true => shard = instance.shard", | ||
| is_global_write.expr(), | ||
| shard.expr() - Expression::Instance(cur_shard), |
Collaborator
There was a problem hiding this comment.
please try this way
let cur_shard = cb.query_shard_id();
cur_shard.expr() // this return `Expression::InstanceScalar()` which make thing work in sumcheck
This was referenced Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items
is_ram_registeris boolean.shard < cur_shard.shard = cur_shardwherecur_shardis fetched from public values.