Conversation
frisitano
previously approved these changes
Jul 28, 2025
Comment on lines
+9
to
+11
| revm = { git = "https://github.com/scroll-tech/revm", branch = "feat/v83", default-features = false, features = ["enable_eip7702", "enable_eip7623"] } | ||
| revm-primitives = { git = "https://github.com/scroll-tech/revm", branch = "feat/v83", default-features = false } | ||
| revm-inspector = { git = "https://github.com/scroll-tech/revm", branch = "feat/v83", default-features = false } |
Contributor
There was a problem hiding this comment.
will we migrate to scroll branch when we merge feat/v83?
Contributor
Author
There was a problem hiding this comment.
yes that was my plan, pointing to v83 for now in order to move forward on the reth upstream merge.
greged93
commented
Jul 29, 2025
| data, | ||
| )); | ||
| let mut h = ScrollHandler::<_, _, EthFrame<EthInterpreter>>::new(); | ||
| h.run_system_call(self) |
Contributor
Author
There was a problem hiding this comment.
run_system_call will skip all the methods that were problematic in the reth system call implementation, which caused the block beneficiary and the system caller to be warmed and include state changes.
frisitano
previously approved these changes
Jul 30, 2025
Comment on lines
+9
to
+11
| revm = { git = "https://github.com/scroll-tech/revm", branch = "scroll", default-features = false, features = ["enable_eip7702", "enable_eip7623"] } | ||
| revm-primitives = { git = "https://github.com/scroll-tech/revm", branch = "scroll", default-features = false } | ||
| revm-inspector = { git = "https://github.com/scroll-tech/revm", branch = "scroll", default-features = false } |
Contributor
There was a problem hiding this comment.
scroll is the default branch so we shouldn't have to specify the branch = argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump revm to v83.