safe document conversions + fix $operators #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addressed issue scslab#38
| @@ -116,7 +121,7 @@ valueAt k = runIdentity . look k | |||
|
|
|||
| -- | Typed value of field in document. Error if missing or wrong type. | |||
| at :: forall v l. (Val l v, Label l) => Key -> Document l -> v | |||
| at k doc = maybe err id (lookup k doc) | |||
| at k doc = fromMaybe err (lookup k doc) | |||
There was a problem hiding this comment.
God I wish I knew about fromMaybe....
|
I'm happy with this for now. I think this means you can't do, e.g. range queries over searchable fields (which in principal is safe), but I'm happier being over-careful in this case and keeping the complexity of code changes to a minimum at this point. I don't think range queries are a must-have right now at all. |
alevy
added a commit
that referenced
this pull request
Mar 22, 2012
safe document conversions + fix $operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safe document conversions + fix $operators
addressed issue #38