Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] fix param override issue #70

Merged
merged 1 commit into from
Mar 6, 2025
Merged

[update] fix param override issue #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion IMDLBenCo/training_scripts/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,9 @@
else:
model_init_params = inspect.signature(model.__init__).parameters
combined_args = {k: v for k, v in vars(args).items() if k in model_init_params}
combined_args.update({k: v for k, v in vars(model_args).items() if k in model_init_params})
for k, v in vars(model_args).items():
if k in model_init_params and k not in combined_args:
combined_args[k] = v

Check warning on line 309 in IMDLBenCo/training_scripts/train.py

View check run for this annotation

Codecov / codecov/patch

IMDLBenCo/training_scripts/train.py#L307-L309 

Added lines #L307 - L309 were not covered by tests
model = model(**combined_args)
# ============================================
evaluator_list = [
Expand Down