(fix): allow init without X and correct shape inferred
#1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1841 +/- ##
==========================================
- Coverage 86.13% 83.75% -2.39%
==========================================
Files 41 41
Lines 6277 6291 +14
==========================================
- Hits 5407 5269 -138
- Misses 870 1022 +152
|
ilan-gold
commented
Jan 28, 2025
| @@ -85,6 +85,40 @@ def _check_2d_shape(X): | |||
| raise ValueError(msg) | |||
|
|
|||
|
|
|||
| def _infer_shape_for_axis( | |||
There was a problem hiding this comment.
2 things about these functions.
- Do they belong in
utils? I see we have a bunch at the top of the file here so not sure - Should we do some sort of validation that all the shapes match? I think this happens anyway elsewhere in the codebase e.g., https://github.com/scverse/anndata/blob/main/src/anndata/_core/aligned_mapping.py#L70-L100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnnDatawithoutXbut withlayerserrors #1816