Skip to content

Commit 27d7a77

Browse files
nikagradkropachev
andcommitted
[#597] Addressing code review comments pt 2.
Co-authored-by: Dmitry Kropachev <[email protected]>
1 parent 0b61d2a commit 27d7a77

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

core/src/main/java/com/datastax/oss/driver/internal/core/protocol/MetadataIdInfo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public class MetadataIdInfo {
99

1010
private MetadataIdInfo() {}
1111

12-
public static boolean parseMetadataId(Map<String, List<String>> supported) {
12+
public static boolean loadFromSupportedOptions(Map<String, List<String>> supported) {
1313
if (!supported.containsKey(SCYLLA_USE_METADATA_ID_STARTUP_OPTION_KEY)) {
1414
return false;
1515
}
@@ -19,7 +19,7 @@ public static boolean parseMetadataId(Map<String, List<String>> supported) {
1919
&& values.get(0).equals(SCYLLA_USE_METADATA_ID_STARTUP_OPTION_VALUE);
2020
}
2121

22-
public static void addOption(Map<String, String> options) {
22+
public static void populateStartupOptions(Map<String, String> options) {
2323
options.put(
2424
SCYLLA_USE_METADATA_ID_STARTUP_OPTION_KEY, SCYLLA_USE_METADATA_ID_STARTUP_OPTION_VALUE);
2525
}

core/src/main/java/com/datastax/oss/driver/internal/core/protocol/ProtocolFeatureStore.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public static ProtocolFeatureStore parseSupportedOptions(
5050
LwtInfo lwtInfo = LwtInfo.loadFromSupportedOptions(options);
5151
ShardingInfo.ConnectionShardingInfo shardingInfo = ShardingInfo.parseShardingInfo(options);
5252
TabletInfo tabletInfo = TabletInfo.loadFromSupportedOptions(options);
53-
boolean metadataIdEnabled = MetadataIdInfo.parseMetadataId(options);
53+
boolean metadataIdEnabled = MetadataIdInfo.loadFromSupportedOptions(options);
5454
return new ProtocolFeatureStore(lwtInfo, shardingInfo, tabletInfo, metadataIdEnabled);
5555
}
5656

@@ -62,7 +62,7 @@ public void populateStartupOptions(@NonNull Map<String, String> options) {
6262
TabletInfo.populateStartupOptions(options);
6363
}
6464
if (metadataIdEnabled) {
65-
MetadataIdInfo.addOption(options);
65+
MetadataIdInfo.populateStartupOptions(options);
6666
}
6767
}
6868

0 commit comments

Comments
 (0)