Apply suggestions from code review

nikagra · dkropachev · web-flow · commit 9122cf0edc62 · 2025-09-24T17:53:02.000+02:00
[#597] Addressing code review comments pt 2. Co-authored-by: Dmitry Kropachev <dmitry.kropachev@gmail.com>
diff --git a/core/src/main/java/com/datastax/oss/driver/internal/core/protocol/MetadataIdInfo.java b/core/src/main/java/com/datastax/oss/driver/internal/core/protocol/MetadataIdInfo.java
@@ -9,7 +9,7 @@ public class MetadataIdInfo {
 
   private MetadataIdInfo() {}
 
-  public static boolean parseMetadataId(Map<String, List<String>> supported) {
+  public static boolean loadFromSupportedOptions(Map<String, List<String>> supported) {
     if (!supported.containsKey(SCYLLA_USE_METADATA_ID_STARTUP_OPTION_KEY)) {
       return false;
     }
@@ -19,7 +19,7 @@ public static boolean parseMetadataId(Map<String, List<String>> supported) {
         && values.get(0).equals(SCYLLA_USE_METADATA_ID_STARTUP_OPTION_VALUE);
   }
 
-  public static void addOption(Map<String, String> options) {
+  public static void populateStartupOptions(Map<String, String> options) {
     options.put(
         SCYLLA_USE_METADATA_ID_STARTUP_OPTION_KEY, SCYLLA_USE_METADATA_ID_STARTUP_OPTION_VALUE);
   }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ public class MetadataIdInfo {`
`9`	`9`
`10`	`10`	`private MetadataIdInfo() {}`
`11`	`11`
`12`		`- public static boolean parseMetadataId(Map<String, List<String>> supported) {`
	`12`	`+ public static boolean loadFromSupportedOptions(Map<String, List<String>> supported) {`
`13`	`13`	`if (!supported.containsKey(SCYLLA_USE_METADATA_ID_STARTUP_OPTION_KEY)) {`
`14`	`14`	`return false;`
`15`	`15`	`}`
`@@ -19,7 +19,7 @@ public static boolean parseMetadataId(Map<String, List<String>> supported) {`
`19`	`19`	`&& values.get(0).equals(SCYLLA_USE_METADATA_ID_STARTUP_OPTION_VALUE);`
`20`	`20`	`}`
`21`	`21`
`22`		`- public static void addOption(Map<String, String> options) {`
	`22`	`+ public static void populateStartupOptions(Map<String, String> options) {`
`23`	`23`	`options.put(`
`24`	`24`	`SCYLLA_USE_METADATA_ID_STARTUP_OPTION_KEY, SCYLLA_USE_METADATA_ID_STARTUP_OPTION_VALUE);`
`25`	`25`	`}`