forked from arcjet/gravity
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: partial support for resources #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sd2k
wants to merge
14
commits into
support-tuples
Choose a base branch
from
support-resources
base: support-tuples
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8d3d19 to
c221a10
Compare
c221a10 to
3c3c5d2
Compare
3c3c5d2 to
f1b9d5e
Compare
f1b9d5e to
d7f9e59
Compare
This change replaces the previous string-specific option handling with a generic method using reflection to check for zero values. It supports optional types beyond just strings by using `reflect.ValueOf().IsZero()` to determine emptiness.
Includes type generation and instructions for tuple lowering/lifting, as well as basic tests. Supports both anonymous tuples and type aliases.
This adds support for resources to gravity. It's a pretty huge change and I'm not sure it's ready for review yet (or maybe ever), but it's a decent PoC. Much of the code was written by Claude with a huge amount of guidance, so it will probably need some cleanup. The main limitations are a lack of support for 'owned' resources as parameters because it involves a lot of complexity re. tracking ownership of resources. Even so this is quite useful for many things. Relates to arcjet#5.
d7f9e59 to
2621de1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for resources to gravity. It's a pretty huge change and I'm not sure it's ready for review yet (or maybe ever), but it's a decent PoC. Much of the code was written by Claude with a huge amount of guidance, so it will probably need some cleanup.
The main limitations are a lack of support for 'owned' resources as parameters because it involves a lot of complexity re. tracking ownership of resources. Even so this is quite useful for many things.
Relates to arcjet#5.