Skip to content

Add parameter to compute privacy score with DCRBaselineProtection metric #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented May 27, 2025

@gsheni gsheni self-assigned this May 27, 2025
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.41%. Comparing base (e978c36) to head (bf7b327).

Files with missing lines Patch % Lines
sdgym/cli/__main__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   65.95%   66.41%   +0.46%     
==========================================
  Files          20       20              
  Lines        1307     1325      +18     
==========================================
+ Hits          862      880      +18     
  Misses        445      445              
Flag Coverage Δ
integration 54.86% <96.77%> (+0.62%) ⬆️
unit 53.05% <38.70%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gsheni gsheni marked this pull request as ready for review May 30, 2025 14:02
@gsheni gsheni requested a review from a team as a code owner May 30, 2025 14:02
@gsheni gsheni requested review from amontanez24 and R-Palazzo and removed request for a team May 30, 2025 14:02
@sdv-team
Copy link
Contributor

@gsheni gsheni requested review from fealho and amontanez24 May 30, 2025 20:21
if compute_privacy_score:
start = get_utc_now()
num_rows = len(synthetic_data)
num_rows_subsample = math.floor(num_rows * 0.60)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the 0.60 coming from? Maybe add an explanation for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DCRBaseline Metric to single table report
4 participants