Allow is_valid to be called on unfit constraints
#2578
Conversation
frances-h
changed the title
is_valid to be called on unfit constraints
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2578 +/- ##
==========================================
- Coverage 98.14% 98.14% -0.01%
==========================================
Files 70 70
Lines 7212 7210 -2
==========================================
- Hits 7078 7076 -2
Misses 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frances-h
force-pushed
the
enterprise-issue-1376-DayZ-constraints
branch
from
5419bac to
0f69f2c
Compare
frances-h
force-pushed
the
enterprise-issue-1376-DayZ-constraints
branch
from
ae7076c to
5e2f85e
Compare
|
|
||
| is_valid = self.programmable_constraint.is_valid(data) | ||
|
|
||
| if self._is_single_table: | ||
| return {self._table_name: is_valid} | ||
| return {table_name: is_valid} |
There was a problem hiding this comment.
Here, should we update the if condition to be the same as in the base cag class:
if isinstance(data, pd.DataFrame) or self._single_table:
There was a problem hiding this comment.
No, this is a different check - the _is_single_table attribute on the harness controls whether we expect a single dataframe or a dataframe dict from the programmable constraint (based on whether it's a SingleTableProgrammableConstraint or a ProgrammableConstraint).
| @@ -99,6 +99,7 @@ def __init__(self, column_names, table_name): | |||
| self.table_name = table_name | |||
| self._joint_column = '#'.join(self.column_names) | |||
| self._combinations = None | |||
| self._fitted = False | |||
There was a problem hiding this comment.
We need it so we can use the FixedCombinations methods on this class. The _is_valid method for FixedCombinations now checks whether or not the constraint has been fit, so we need it set on this class for the method to actually work without erroring.
frances-h
force-pushed
the
enterprise-issue-1376-DayZ-constraints
branch
from
44908a6 to
441d115
Compare
CU-86b586xqm
Adds metadata as an optional parameter to
is_valid(and a required parameter to the constraint method_is_valid) so that the method can be called on an unfit constraint when running DayZ.