Skip to content

Improve CAG validation error message #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Improve CAG validation error message #2587

wants to merge 9 commits into from
+164 −56

Conversation

R-Palazzo
Copy link
Contributor

Resolve #2496
CU-86b4v53zt

@R-Palazzo R-Palazzo requested review from rwedge and frances-h June 23, 2025 12:55
@R-Palazzo R-Palazzo self-assigned this Jun 23, 2025
@R-Palazzo R-Palazzo requested a review from a team as a code owner June 23, 2025 12:55
@sdv-team
Copy link
Contributor

Task linked: CU-86b4v53zt SDV - Improve CAG validation error message #2496

@R-Palazzo R-Palazzo removed the request for review from a team June 23, 2025 13:00
@codecov Codecov
Copy link

codecov bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (f91a928) to head (a1071b8).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2587      +/-   ##
==========================================
- Coverage   98.14%   98.12%   -0.02%     
==========================================
  Files          70       70              
  Lines        7212     7217       +5     
==========================================
+ Hits         7078     7082       +4     
- Misses        134      135       +1
Flag Coverage Δ
integration 76.25% <78.57%> (+0.16%) ⬆️
unit 96.85% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@R-Palazzo R-Palazzo force-pushed the issue-2496-cag-validation branch from bcc4699 to e2db7c1 Compare June 23, 2025 15:41
frances-h
frances-h reviewed Jun 23, 2025
View reviewed changes
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Should we update the error messages for the other constraints as well, or do you think those should be done in separate PRs?

@R-Palazzo R-Palazzo force-pushed the issue-2496-cag-validation branch 2 times, most recently from ee3ee7e to c3ec328 Compare June 24, 2025 09:18
@R-Palazzo R-Palazzo force-pushed the issue-2496-cag-validation branch from c3ec328 to 955628a Compare June 24, 2025 16:25
@R-Palazzo R-Palazzo requested a review from frances-h June 25, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge Awaiting requested review from rwedge

@frances-h frances-h Awaiting requested review from frances-h

At least 2 approving reviews are required to merge this pull request.

Assignees

@R-Palazzo R-Palazzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CAG validation error message
3 participants
@R-Palazzo @sdv-team @frances-h