Add UniCase::contains()
#52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryZe
reviewed
Nov 9, 2022
|
|
||
| loop { | ||
| let p = match pat.next() { | ||
| None => break 'out true, |
There was a problem hiding this comment.
All these breaks could just be returns right? I think that would be simpler
There was a problem hiding this comment.
In fact, depending on if there's a minimal supported rust version, you could even write
let Some(p) = pat.next() else { return true };(The build.rs seems to imply there is, so this probably is too fancy).
|
What is the status of this PR? Is this simply waiting for the feedback in question to be applied to take it over the finish line? If so I would be happy to do the honors |
npwoods
reviewed
May 5, 2025
| #[inline] | ||
| pub fn contains<S2: AsRef<str>>(&self, pat: &UniCase<S2>) -> bool { | ||
| match (&self.0, &pat.0) { | ||
| (&Encoding::Ascii(ref x), &Encoding::Ascii(ref p)) => x.as_ref().contains(p.as_ref()), |
There was a problem hiding this comment.
Won't this in practice be a case sensitive contains?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
UniCase::contains()to test if one unicode string contains another.This somehow conflict with / workaround #47