Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario: One may want to deserialize into a
HashMap<String, String>
from, say, a config file containing a map with arbitrary keys. There's aconfig-rs
crate for this, but due to rust-cli/config-rs#531, the deserialized keys are always converted to lowercase. The consequence is catastrophic: for aMap<user_id, priority>
whereuser_id
might contain upper cased letters, anyone forgetting to add a.to_ascii_lowercase()
will findNone
from the hash map.Many crates also have a special
serde
feature for serialize/deserialize usingserde_json
or other similar libraries built upon theserde
crate. So maybe we should add this feature into unicase as well.