[fix] LESS sourcemaps broken in less-plugin-clean-css v1.6.0 #4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ``less-plugin-clean-css`` lacks some maintenance: the sourcemaps are broken since v1.6.0 (08/2024) [1] - [1] less/less-plugin-clean-css#42 Closes: searxng#4143 Signed-off-by: Markus Heiser <[email protected]>
|
This means that CSS will no longer be minified and thus possibly our CSS files are larger in size? I don't think that the change in size would really matter, we don't have that much CSS anyways in SearXNG (only some kB), which loads fast enough anyways. |
Bnyro
approved these changes
Jan 20, 2025
Sadly "yes" .. I hope the issue will be fixed We can implement some quirks here .. but I think its better to wait for a fix from upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
less-plugin-clean-csslacks some maintenance: the sourcemaps are broken since v1.6.0 (08/2024) [1]Closes: #4143