Add tonemappers: AgX and Tony McMapface #3475
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent the last year playing with many different tonemappers to try to get Second Life to look as beautiful as possible, especially with PBR being live now. I've been working on this for quite a while.
The AgX tonemapper stood out to me because it's the default in Blender and precedes Filmic, which has issues with bright lights turning unrealistically saturated. As far as I know, it's the more mathematically correct tonemapper out of the two I've added. Any Blender user will immediately recognize the name and thus art made in Blender and brought into Second Life can now look more 1 to 1 which may be desirable. It's a good tonemapper and I prefer it over ACES or Khronos PBR Neutral.
Tony McMapface is an interesting tonemapper. It tries to stay close to linear whilst also being carefully tuned for our perceptual phenomena. It's not as mathematically correct as AgX, but in my personal opinion, it's simply stunning how it can really bring out a well built sim. I've been using this tonemapper in many other projects and absolutely love using it. I really do think it's worth considering. I've certainly enjoyed taking screenshots with it and others have asked me how I get the colors to look so nice. https://github.com/h3r2tic/tony-mc-mapface
I used the AgX implementation recently added to Godot as it's a near perfect approximation using sigmoid curves instead of lookup tables. godotengine/godot#87260
Unfortunately Tony McMapface requires a lookup table, but I've added
tonemapTex
as a shader uniform to potentially use in the future. I also had to fit the LUT (originally in 48x48x48), into a power of two texture which is a little awkward, but it seems to have no consequences. I'll include the script I made which creates the SL compatible LUT image. godotengine/godot#97095I would prefer not to disclose the sim location.
I personally really like how Tony McMapface looks, however AgX can be a really good base to color correct with and I'm sure many residents would appreciate it.
Thank you all for the wonderful changes in Second Life. I'm always trying to improve the software some way or another and absolutely love keeping up with the development.