feat: use RELATED_IMAGES_ environment variables to configure operand's images #812
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: osmman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
osmman
force-pushed
the
tturek/related-images
branch
from
3057129 to
dc7b201
Compare
osmman
changed the title
| } | ||
|
|
||
| // parseConfigFile parses an embedded `.env` content and returns a map of key-value pairs. | ||
| func parseConfigFile(envContent string) (map[Image]string, error) { |
There was a problem hiding this comment.
Did you considered using Viper https://github.com/spf13/viper ?
There was a problem hiding this comment.
Did not thing for this case. We can move our configuration of operator to be managed by it.
osmman
force-pushed
the
tturek/related-images
branch
from
99976e7 to
1c8328a
Compare
osmman
force-pushed
the
tturek/related-images
branch
from
1c8328a to
1a0f6ff
Compare
osmman
changed the title
osmman
changed the title
osmman
force-pushed
the
tturek/related-images
branch
2 times, most recently
from
7e26eee to
83f4538
Compare
osmman
force-pushed
the
tturek/related-images
branch
2 times, most recently
from
2431c20 to
83f4538
Compare
osmman
force-pushed
the
tturek/related-images
branch
from
83f4538 to
fe9cc6c
Compare
|
/test tas-operator-e2e |
|
Openshift CI job will fail untill https://github.com/openshift/release/blob/master/ci-operator/config/securesign/secure-sign-operator/securesign-secure-sign-operator-main.yaml#L62-L83 will be modified to work with new changes. |
|
/override ci/prow/tas-operator-e2e |
|
@osmman: Overrode contexts on behalf of osmman: ci/prow/tas-operator-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This pull request introduces a new feature that allows the Operator manager to utilize
RELATED_IMAGES_*environment variables for image configurations. This change allows operator-sdk to generate bundle image with relatedImages meta data which are used for disconnected environment. Additionally, it includes several refactoring changes to improve deployment for different environments Kubernetes/Openshift.Key Features
RELATED_IMAGES_environment variables for image configurations.CONFIG_DEFAULTfor dynamic configuration based on theOPENSHIFTvariable.internal/images.