Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Braze regions server #2762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Braze regions server #2762

wants to merge 1 commit into from
+5 −3

Conversation

davidbielik
Copy link
Contributor

@davidbielik davidbielik commented Feb 25, 2025 •
edited
Loading

Adds new regions to braze server destinations

Testing

image
  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@davidbielik davidbielik requested a review from a team as a code owner February 25, 2025 00:21
@davidbielik davidbielik mentioned this pull request Feb 25, 2025
Closed
5 tasks
@davidbielik
Copy link
Contributor Author

@brennan can we get this merged please?

@brennan brennan added triaged Acknowledged by the Segment team, but not yet scheduled for review/deploy. eng-acknowledged This PR has been acknowledged by the engineering team. and removed triaged Acknowledged by the Segment team, but not yet scheduled for review/deploy. labels Mar 7, 2025
marinhero
marinhero requested changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@marinhero marinhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @davidbielik can you patch this test please? We should be good to go aftwerwards.
Screenshot 2025-03-11 at 12 37 23 PM

@davidbielik
Copy link
Contributor Author

@marinhero any suggestions on what I need to do? Tests pass for me

image

@marinhero
Copy link
Contributor

Ah! I think the test snapshot might be out of date. Let's try these instructions. Let me know how it goes!

@marinhero
Copy link
Contributor

Also, looks like this was opened right in the middle of our node 22 update. Make sure you pull the latest version of the repo so that version of the CI checks can run.

@davidbielik
Copy link
Contributor Author

davidbielik commented Mar 19, 2025 •
edited by marinhero
Loading

Ah! I think the test snapshot might be out of date. Let's try these instructions. Let me know how it goes!

Do you have a public link?

@marinhero
Copy link
Contributor

@davidbielik Here it is: https://github.com/segmentio/action-destinations/blob/main/docs/testing.md#snapshot-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinhero marinhero marinhero requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
eng-acknowledged This PR has been acknowledged by the engineering team. mode:cloud partner-eng-review (cloud) team:external
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidbielik @marinhero @brennan @joe-ayoub-segment