Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [STRATCONN-5473] Add destinationInstanceID and subscriptionId to support audience fanout #2786

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itsarijitray
Copy link
Contributor

@itsarijitray itsarijitray commented Mar 10, 2025

JIRA:
https://segment.atlassian.net/browse/STRATCONN-5473

Accommodate subscriptionId as part of file path to support audience fanout.

Refer: https://docs.google.com/document/d/1Fx_vcI_VEbJPhm3tUprAFSvj7UCB9mxkW5ZVTmm5Nrs/edit?usp=sharing

Testing

Testing on stage
As you can see, S3 file is now getting created with the new file format:
Screenshot 2025-03-12 at 4 39 49 PM
Screenshot 2025-03-12 at 4 40 03 PM
Screenshot 2025-03-12 at 4 40 24 PM

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Sorry, something went wrong.

…ort audience fanout
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (30aa569) to head (59ddabb).

Files with missing lines Patch % Lines
...ions/liveramp-audiences/audienceEnteredS3/index.ts 33.33% 2 Missing ⚠️
...ns/liveramp-audiences/audienceEnteredSftp/index.ts 33.33% 2 Missing ⚠️
...s/src/destinations/liveramp-audiences/awsClient.ts 0.00% 2 Missing ⚠️
...s/src/destinations/the-trade-desk-crm/awsClient.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2786      +/-   ##
==========================================
- Coverage   78.95%   78.42%   -0.54%     
==========================================
  Files        1094     1041      -53     
  Lines       21702    18934    -2768     
  Branches     4399     3631     -768     
==========================================
- Hits        17135    14849    -2286     
+ Misses       3337     2861     -476     
+ Partials     1230     1224       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant