Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STRATCONN-5488] Introduces batch_keys field (pilot) #2791

Merged
merged 5 commits into from
Mar 20, 2025
Merged

Conversation

varadarajan-tw
Copy link
Contributor

@varadarajan-tw varadarajan-tw commented Mar 12, 2025

This PR

  • updates fields type in ActionDefinition to specify specific shape for batch_keys
  • adds some validations for batch_keys field so that we can catch configuration errors earlier.

Testing

image
image

Scenario: 2
image
image

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.85%. Comparing base (25c9d2a) to head (904b779).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/commands/validate.ts 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2791      +/-   ##
==========================================
+ Coverage   78.36%   78.85%   +0.49%     
==========================================
  Files        1042     1095      +53     
  Lines       18937    21718    +2781     
  Branches     3646     4364     +718     
==========================================
+ Hits        14840    17126    +2286     
- Misses       2860     3349     +489     
- Partials     1237     1243       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@varadarajan-tw varadarajan-tw changed the title Adds validations for batch_keys field [STRATCONN-5488] Adds validations for batch_keys field Mar 12, 2025
@varadarajan-tw varadarajan-tw marked this pull request as ready for review March 12, 2025 06:24
@varadarajan-tw varadarajan-tw requested a review from a team as a code owner March 12, 2025 06:24
@varadarajan-tw varadarajan-tw changed the title [STRATCONN-5488] Adds validations for batch_keys field [STRATCONN-5488] Introduces batch_keys field (pilot) Mar 17, 2025
@AnkitSegment AnkitSegment merged commit d303fd4 into main Mar 20, 2025
20 of 21 checks passed
@AnkitSegment AnkitSegment deleted the add-validation branch March 20, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants