Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Smart Hashing] [Snap Audience] Implement Smart hashing for Snap Audience #2800

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

harsh-joshi99
Copy link
Contributor

This PR implements smart hashing for Snap Audience.
The new implementation maintains the functionality of pre existing smart hashing in Snap Audience.

Testing

Testing Document
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.10%. Comparing base (d126d73) to head (24aff9f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2800      +/-   ##
==========================================
- Coverage   78.11%   78.10%   -0.02%     
==========================================
  Files        1042     1042              
  Lines       19005    18996       -9     
  Branches     3687     3685       -2     
==========================================
- Hits        14845    14836       -9     
  Misses       2875     2875              
  Partials     1285     1285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a question and a comment

varadarajan-tw
varadarajan-tw previously approved these changes Mar 19, 2025
@harsh-joshi99 harsh-joshi99 merged commit 02851d4 into main Mar 20, 2025
14 checks passed
@harsh-joshi99 harsh-joshi99 deleted the STRATCONN-5541/smart-hashing-Snap-Audiences branch March 20, 2025 05:30
@varadarajan-tw varadarajan-tw restored the STRATCONN-5541/smart-hashing-Snap-Audiences branch March 24, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants