[Google Ads] Standardize Phone Number Formatting #2810
Conversation
There was a problem hiding this comment.
The original implementation was not correctly formatting phone numbers before hashing, hence why the tests changed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2810 +/- ##
==========================================
- Coverage 78.36% 78.35% -0.02%
==========================================
Files 1042 1042
Lines 18937 18927 -10
Branches 3646 3634 -12
==========================================
- Hits 14840 14830 -10
Misses 2860 2860
Partials 1237 1237 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| request_object.userIdentifiers.push({ | ||
| hashedPhoneNumber: isHashedInformation(payload.phone_number) ? payload.phone_number : hash(phoneNumber) | ||
| hashedPhoneNumber: formatPhone(payload.phone_number, payload.phone_country_code) |
There was a problem hiding this comment.
Will existing implementations of this action continue to send data unchanged?
There was a problem hiding this comment.
Currently these actions are not formatting the phone numbers correctly to E164 so if the phone numbers are coming in not in E164 technically it will change to format it correctly. But the ones that come correctly formatted will not be changed.
STRATCONN-5475
Research doc
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.