-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STRATCONN-5601] add subscription object support for unsubscribeProfile action in Klaviyo #2814
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2814 +/- ##
==========================================
- Coverage 78.54% 77.96% -0.59%
==========================================
Files 1095 1042 -53
Lines 21775 19009 -2766
Branches 4467 3699 -768
==========================================
- Hits 17104 14820 -2284
+ Misses 3362 2886 -476
+ Partials 1309 1303 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left one nit.
Also what happens when subscription object is empty? Does the API throw any error?
packages/destination-actions/src/destinations/klaviyo/functions.ts
Outdated
Show resolved
Hide resolved
Sure, I checked this. This block actually filters out profile with no email or phone number so this object doesn't get created for this case. |
JIRA: https://segment.atlassian.net/browse/STRATCONN-5601
As per Klaviyo’s guide and their changelog, adding subscription object in the unsubscribeProfile action to be at parity with Klaviyo.
Testing
Tested successfully in local:
Screen.Recording.2025-03-20.at.6.59.49.PM.mov