Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STRATCONN-5601] add subscription object support for unsubscribeProfile action in Klaviyo #2814

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

itsarijitray
Copy link
Contributor

@itsarijitray itsarijitray commented Mar 19, 2025

JIRA: https://segment.atlassian.net/browse/STRATCONN-5601

As per Klaviyo’s guide and their changelog, adding subscription object in the unsubscribeProfile action to be at parity with Klaviyo.

Testing

Tested successfully in local:

Screen.Recording.2025-03-20.at.6.59.49.PM.mov
  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.96%. Comparing base (61eb683) to head (0f4ff21).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2814      +/-   ##
==========================================
- Coverage   78.54%   77.96%   -0.59%     
==========================================
  Files        1095     1042      -53     
  Lines       21775    19009    -2766     
  Branches     4467     3699     -768     
==========================================
- Hits        17104    14820    -2284     
+ Misses       3362     2886     -476     
+ Partials     1309     1303       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsarijitray itsarijitray marked this pull request as ready for review March 20, 2025 13:37
@itsarijitray itsarijitray requested a review from a team as a code owner March 20, 2025 13:37
@itsarijitray itsarijitray changed the title add subscription object support for unsubscribeProfile action in Klaviyo [STRATCONN-5601] add subscription object support for unsubscribeProfile action in Klaviyo Mar 20, 2025
Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left one nit.
Also what happens when subscription object is empty? Does the API throw any error?

@itsarijitray
Copy link
Contributor Author

Nice work! Left one nit. Also what happens when subscription object is empty? Does the API throw any error?

Sure, I checked this. This block actually filters out profile with no email or phone number so this object doesn't get created for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants