Skip to content

Conversation

mohamadhase
Copy link
Contributor

@mohamadhase mohamadhase commented Aug 24, 2025

PR Summary: Add FullSession Browser Destination

Overview

This PR introduces a new browser-mode destination for FullSession, a session recording and analytics platform. The destination enables customers to stream Segment events to FullSession for user identification, event tracking, and page visit recording.

🚀 New Features

1. FullSession Browser Destination

  • Mode: Device/Browser mode destination
  • Package: @segment/analytics-browser-actions-fullsession
  • Integration: Uses FullSession's JavaScript SDK to track user interactions

2. Three Actions Implemented

Identify User Action

  • Maps Segment identify events to FullSession user identification

Record Event Action

  • Maps Segment track events to FullSession custom events

Visit Page Action

  • Maps Segment page events to FullSession page visit tracking

Test Coverage

  • 33 total tests across all actions and main destination
  • 100% action coverage with edge cases and error scenarios

🔧 Configuration

Required Settings

  • Customer ID: FullSession account identifier for initialization

Default Subscriptions

  • type = "identify" → Identify User action
  • type = "track" → Record Event action
  • type = "page" → Visit Page action

Test Coverage

  • 33 total tests across all actions and main destination

  • 100% action coverage with edge cases and error scenarios

  • Added unit tests for new functionality

  • Tested end-to-end using the local server

  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.

  • [Segmenters] Tested in the staging environment

  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@joe-ayoub-segment
Copy link
Contributor

Hi @mohamadhase thanks for raising this PR for a new Web Integration.
I had a quick look through the code and I think it would be worth having a call to discuss.
Would you be able to schedule some time with me please?
https://calendly.com/joe_ayoub

Best regards,
Joe

@mohamadhase
Copy link
Contributor Author

mohamadhase commented Aug 25, 2025

Hi @joe-ayoub-segment,

Thank you for reviewing the PR. I’ve booked a meeting through your Calendly link.
Also, I’ve pushed some changes to address the CI build issues.

Best regards,
Mohammed

… type definitions, and enhance test cases for identifyUser and visitPage actions.
@mohamadhase
Copy link
Contributor Author

Hi @joe-ayoub-segment ,
I’ve resolved the comments we discussed in our meeting. I suggest proceeding with the deploy so we can test it further.

@joe-ayoub-segment
Copy link
Contributor

Hi @mohamadhase we still have some failing tests.
image

Are you able to take a look please?

@joe-ayoub-segment joe-ayoub-segment merged commit b246aca into segmentio:main Sep 4, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants