-
Notifications
You must be signed in to change notification settings - Fork 283
STRATCONN-4121: Customer.io timestamp fix to convert ISO-8601 timestamp to Unix #3212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STRATCONN-4121: Customer.io timestamp fix to convert ISO-8601 timestamp to Unix #3212
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3212 +/- ##
=======================================
Coverage 79.62% 79.63%
=======================================
Files 1177 1177
Lines 21703 21704 +1
Branches 4220 4221 +1
=======================================
+ Hits 17282 17283 +1
Misses 3679 3679
Partials 742 742 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e95e92a
to
d9ca0cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure the tests are passing, before this is ready for release
…p to Unix- updated snapshots
2abf845
…timestamp to Unix- updated snapshots" This reverts commit 2abf845.
Hi @kkolhe-twilio does this change warrant an end to end test before we deploy? Great that the unit tests are passing, but it would be nice to see an end to end test on local using the Actions Tester or on Staging, if possible. |
@joe-ayoub-segment I have tested it in staging and in local using actions-tester and it works as expected. I have also added a demo of it working in staging in the PR description. |
Hi @kkolhe-twilio PR deployed |
This pull request is for fixing Customer.io timestamp validation to properly handle high-precision fractional seconds in ISO 8601 date strings.
Screen.Recording.2025-08-29.at.11.57.04.AM.mov
Testing improvements:
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.