Skip to content

[MAIN] [STRATCONN-6111] : [Braze] Remove devicePropertyAllowList in braze SDK initialization for empty string array and only pass devicePropertyAllowList when there is a non empty string is filled from UI side #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

[MAIN] [STRATCONN-6111] : [Braze] Remove devicePropertyAllowList in braze SDK initialization for empty string array and only pass devicePropertyAllowList when there is a non empty string is filled from UI side #3218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/browser-destinations/destinations/braze/src/__tests__/initialization.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,4 +136,34 @@ describe('initialization', () => {
expect(openSessionSpy).toHaveBeenCalled()
expect(logCustomEventSpy).toHaveBeenCalledWith('FIFA', { goat: 'deno' })
})

test('passes devicePropertyAllowlist to Braze SDK initialization', async () => {
const devicePropertyAllowlist = ['os', 'browser']
const [event] = await brazeDestination({
api_key: 'b_123',
endpoint: 'endpoint',
sdkVersion: '3.5',
doNotLoadFontAwesome: true,
devicePropertyAllowlist,
subscriptions: [
{
partnerAction: 'trackEvent',
name: 'Track Event',
enabled: true,
subscribe: 'type = "track"',
mapping: {
eventName: { '@path': '$.event' },
eventProperties: { '@path': '$.properties' }
}
}
]
})

const initializeSpy = jest.spyOn(destination, 'initialize')
await event.load(Context.system(), {} as Analytics)

// Check that the config passed to initialize contains the allowlist
const callArgs = initializeSpy.mock.calls[0][0]?.settings || {}
expect(callArgs.devicePropertyAllowlist).toEqual(devicePropertyAllowlist)
})
})
13 changes: 12 additions & 1 deletion packages/browser-destinations/destinations/braze/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,20 @@ export const destination: BrowserDestinationDefinition<Settings, BrazeDestinatio
// @ts-expect-error same as above.
subscriptions,
deferUntilIdentified,
devicePropertyAllowlist,
...expectedConfig
} = settings

type BrazeConfig = typeof expectedConfig & {
devicePropertyAllowlist?: string[]
}
const config: BrazeConfig = { ...expectedConfig }
if (Array.isArray(devicePropertyAllowlist)) {
if (devicePropertyAllowlist.some((item) => item.trim() !== '')) {
config.devicePropertyAllowlist = devicePropertyAllowlist
}
}

const version = sdkVersion ?? defaultVersion

resetUserCache()
Expand All @@ -351,7 +362,7 @@ export const destination: BrowserDestinationDefinition<Settings, BrazeDestinatio
if (
!client.instance.initialize(api_key, {
baseUrl: window.BRAZE_BASE_URL || endpoint,
...expectedConfig
...config
})
) {
return false
Expand Down
Loading