Skip to content

Conversation

@joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented Oct 29, 2025

enhancements to Google Enhanced Conversions.

  1. Add new field to collect IP address.
  2. Adds new session_attributes_encoded field
  3. Adds a default mapping to the session_attributes_encoded field.

Testing

Unit tests updated.

Tested in staging - though without credentials (as we don't have any! )

image

@joe-ayoub-segment joe-ayoub-segment marked this pull request as ready for review October 30, 2025 12:34
@joe-ayoub-segment joe-ayoub-segment requested a review from a team as a code owner October 30, 2025 12:34
sayan-das-in
sayan-das-in previously approved these changes Oct 30, 2025
@joe-ayoub-segment joe-ayoub-segment changed the title STRATCONN-6214 - [Google Ads Conversions] - Enhancements STRATCONN-6214 - [Google Enhanced Conversions] - Enhancements Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 56.92308% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.91%. Comparing base (9ed58fa) to head (44bdde0).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...nhanced-conversions/uploadClickConversion/index.ts 53.33% 2 Missing and 12 partials ⚠️
...hanced-conversions/uploadClickConversion2/index.ts 53.33% 2 Missing and 12 partials ⚠️

❌ Your patch check has failed because the patch coverage (56.92%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3376      +/-   ##
==========================================
- Coverage   80.00%   79.91%   -0.10%     
==========================================
  Files        1211     1211              
  Lines       22353    22421      +68     
  Branches     4411     4460      +49     
==========================================
+ Hits        17884    17918      +34     
- Misses       3689     3699      +10     
- Partials      780      804      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants