Skip to content

Conversation

@varadarajan-tw
Copy link
Contributor

@varadarajan-tw varadarajan-tw commented Oct 31, 2025

This PR introduces a new error type for Adobe Targets known issue. Adobe Target takes time to create profile and it seems like it returns 500 too often. Instead of assigning the error type as 500, we are assigning a new error type

Testing

Ran unit tests, local E2E tests

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.32%. Comparing base (3c3295e) to head (b12c96e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3385      +/-   ##
==========================================
+ Coverage   79.98%   80.32%   +0.34%     
==========================================
  Files        1211     1264      +53     
  Lines       22356    25208    +2852     
  Branches     4407     5201     +794     
==========================================
+ Hits        17881    20249    +2368     
- Misses       3695     4158     +463     
- Partials      780      801      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants