Skip to content

Conversation

@joe-ayoub-segment
Copy link
Contributor

Stackadapt - Remove user_id from PROFILE_DEFAULT_FIELDS

Testing

Unit tests updated.
Destination not in use yet.

@joe-ayoub-segment
Copy link
Contributor Author

Copies code from #3384 but fixes unit tests.
FYI @Vanessa-SSY

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.96%. Comparing base (3f439aa) to head (e6ff64e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3389      +/-   ##
==========================================
- Coverage   80.32%   79.96%   -0.36%     
==========================================
  Files        1264     1211      -53     
  Lines       25207    22356    -2851     
  Branches     5216     4407     -809     
==========================================
- Hits        20248    17878    -2370     
+ Misses       4173     3697     -476     
+ Partials      786      781       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Vanessa-SSY Vanessa-SSY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Vanessa-SSY
Copy link
Contributor

@joe-ayoub-segment are we planning to get this merged today?

@joe-ayoub-segment
Copy link
Contributor Author

Hi Vanessa, it will go out later today.

@joe-ayoub-segment joe-ayoub-segment merged commit 8759ad5 into main Nov 5, 2025
14 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the stackadapt-bugfix branch November 5, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants